Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: fix the bind fields with quotes or slashes (#11671) #11726

Merged
merged 2 commits into from
Aug 13, 2019
Merged

bindinfo: fix the bind fields with quotes or slashes (#11671) #11726

merged 2 commits into from
Aug 13, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 13, 2019

cherry-pick #11671 to release-3.0

What problem does this PR solve?

Fix #11708

tidb>  CREATE TABLE t (a varchar(512) DEFAULT NULL, KEY idx (a));
Query OK, 0 rows affected (0.01 sec)

tidb> CREATE GLOBAL BINDING FOR  select * from t where a BETWEEN "a" and "b" USING select * from t use index(idx) where a BETWEEN "a" and "c";
ERROR 1105 (HY000): line 1 column 48 near "\"a\" and \"c\""

What is changed and how it works?

Remove the function of getEscapeCharacter .

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 13, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Aug 13, 2019
Merged
@sre-bot sre-bot added sig/planner SIG: Planner type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Aug 13, 2019
@sre-bot sre-bot requested review from alivxxx and qw4990 August 13, 2019 05:38
zz-jason
zz-jason reviewed Aug 13, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2019
alivxxx
alivxxx approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit c7ee0dd into pingcap:release-3.0 Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @zz-jason @alivxxx @zimulala